#3671 Add debug handler to print debug logs
Closed by farhaan. Opened by farhaan.
farhaan/pagure fix-debug-logs  into  master

Download 3671.patch

This commit adds the debug handler to print debug logs,
this helps to get the debug statement on the console.
This specially helps in seeing logs on the docker console.

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

I'd rather have this change in the docker file when the container is built. I do not think we should log on debug by default

I agree I would rather have a mechanism where we could turn it off or on, it doesn't make sense only in dockerfile as well what about non-docker development environment, I think @vivekanand1101 was saying the he couldn't see email tokens.

So I am just wondering how do we print "debug" logs only when a --debug flag is passed to the runserver.py

rebased onto 38766c338d7464444daafd341888982410c4f77c

rebased onto 38ce9f52725faf94f316d169e1d978b24f26351a

So I am just wondering how do we print "debug" logs only when a --debug flag is passed to the runserver.py

You can inject what you want in the config at this stage, including changing the logging level for this ;-)

But how do we do that in a normal environment? The one without docker?

But how do we do that in a normal environment? The one without docker?

Things a printed to stdout when ran via runserver.py, in vagrant I believe this is accessible in journalctl

@farhaan do you mind if we close this PR for now? We can then just open a new one when we have this change ready, what do you think?

sure @pingou :)

Pull-Request has been closed by farhaan

Metadata