pagure

#3748 Make sure that ticket changes don't get duplicated
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure fixtickets  into  master

Download 3748.patch

This checks whether a push is done by someone changing things in the
tickets on the web UI, and does not trigger the ticket hook for that.

This resulted in a ticket constantly opening and closing itself:
- Ticket is open, person closes. Database is updated
- Pre-receive hooks trigger, at which point the ticket is still Open in the
ticket repo
- Database is updated with the repo contents, opening the ticket repo
- The closing commit goes through
- The database update for opening the ticket goes through, reverting the close
- and so forth

Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org

:thumbsup: thanks for tracking this down.

I do wonder if this shouldn't be a post_receive instead of a pre_receive though, this sounds like a copy/paste error.
What do you think?

I was thinking the exact same this morning.
This does sound like a post-receive indeed.

I confirm, it used to be post-receive before we ported it to the new arch

rebased onto 14dd1d2ea89bf0eeeba7662d015d68ff8afd36b4

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.