pagure

#3770 Fix #3657 Update README with details on the new testing script(s)
Closed by jingjing. Opened by jingjing.
jingjing/pagure jingjing/fix-readme  into  master

Download 3770.patch

I follow the instructions to setup the development environment on Fedora 28, I need to install python3-devel as a dependency to get pygit2 compiled and installed. Tried the python runtests.py run locally, not sure if I missed something, the tests stuck after saying "Starting the workers".

Going to read the source code to find out why, in the meanwhile, please help to review my changes, and I will update this PR after discussions with you later.

Let's add sudo directly since it will be necessary (for these commands, not for the others)

python runtests.py --help then :)

Mind also poking at the docfolder? Should be the doc/contributing.rst iirc

Sure, I'm working on it. Will update the PR soon.

1 new commit added

  • Update PR#3770

1 new commit added

  • Update doc/contributing.rst

@pingou I've updated the PR, please kindly help to review. It's pretty late now at my timezone, I will check back tomorrow;-)
You may assign some easy fixes to me to ramp up, thank you.

Looks all good to me, could you squash all your commits into one, rebase on the top of master.

Also for the commit message, I prefer to keep the "Fix in the body of the message rather than in the first line.

Thanks! :)

@pingou Thanks for your comments:-)

I've squashed my commits into one, rebase on master, and update the commit the message.

Please refer to the new PR #3777

Pull-Request has been closed by jingjing
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.