#383 Swap titles around when viewing PR
Closed by pingou. Opened by dhrish20.
dhrish20/pagure bug330  into  master

Download 383.patch
no initial comment

This isn't quite the idea.

The ticket is about the page itself, not the headers and the page, so it's about inverting the elements h2 and h3 in the top of the page when it makes sense

@pingou could you please check the latest commit, if that's alright?

@pingou could you please check the latest commit, if that's alright?

This looks good from looking at it here, I'll have to test it locally to confirm though.

Did you run the test suite?

yes i did.

All of them passed except this one "test_progit_flask_ui_fork.py".

Do you want to try fixing it then?

Ok I have rework the pull-request page based on your work, making it nicer and I adjusted the unit-tests to pass.

Thanks for your work, I'll close this PR and re-open one with both our changes.

Metadata