pagure

#4058 Bypass old hooks rather than using non-existing symlinks
Merged by pingou. Opened by pingou.
bypass_old_hooks  into  master

Download 4058.patch

When we moved to the runner architecture, we changed the way hooks are
called. During this move, we changed all of our existing hooks into
non-existing symlinks pointing to '/does/not/exists' and we were checking
if the files on disk were matching this target or not.
This created a few issue when releasing pagure:
- python setup.py sdist resolve symlinks as part of the archive creation
process
Reported in https://pagure.io/pagure/issue/3782
- Building pagure failed on some system because these symlinks does not
exist
Reported in https://pagure.io/pagure/issue/3706

So in this commit we are dropping the use of symlink and just making
pagure ignore all the hook it could have created.

Fixes https://pagure.io/pagure/issue/3782
Fixes https://pagure.io/pagure/issue/3706

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • When calling the hooks, ignore the samples that git inserts

rebased onto 79cb3c9a3a1276bd3175db0d46de3b3c51305d9e

rebased onto 498ef54b08d25ad379d9bc15320496b971f3cf6c

rebased onto 498ef54b08d25ad379d9bc15320496b971f3cf6c

rebased onto 7db5e04361731f65fd6f48e1c4157d4f2326eef1

rebased onto 668ab8818a0045ad1ff49350664e9f9687714bf1

rebased onto 3bded87373a3eef6b4a500d3759185bc78a0b0ad

:+1:

rebased onto 4937c4e266b2d1a2583b793128f87c66c96a7d5e

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.