This is being proposed for review/input but I'd like to add some basic tests before it gets merged :)

The following commit Allow filtering the issue list by the close status looks good to me

@cverna and the first one? :)

Postgresql support full text search and this is also supported in sqlalchemy, it might be more performant to use it here, since the the column used for search can be indexed.

SQLalchemy docs --> https://docs.sqlalchemy.org/en/latest/dialects/postgresql.html#full-text-search

Postgresql support full text search and this is also supported in sqlalchemy, it might be more performant to use it here, since the the column used for search can be indexed.

It can be indexed in postgresql but not in mysql/mariadb which doesn't support indexing TEXT field (only VARCHAR can be), so that would make pagure officially not compatible with mysql/mariadb (which may make @arrfab sad)

Postgresql support full text search and this is also supported in sqlalchemy, it might be more performant to use it here, since the the column used for search can be indexed.

It can be indexed in postgresql but not in mysql/mariadb which doesn't support indexing TEXT field (only VARCHAR can be), so that would make pagure officially not compatible with mysql/mariadb (which may make @arrfab sad)

Ha good point

This will allow to search the descriptions of the issues also not only comments.

Ok second commit LGTM too :)

Thanks for the review, I'll add some tests before merging this one though :)

LGTM

:thumbsup:

Thanks for the reviews folks! :)