#4099 Store the user who closed a ticket in the database.
Merged by pingou. Opened by cverna.
cverna/pagure fix_3932  into  master

Download 4099.patch

Fixes 3932

Signed-off-by: Clement Verna cverna@tutanota.com

Are these rows really needed? The content of this field shouldn't change much b/w test runs no?

Should we check a little more context here? To ensure that user is mentioned where we expect it to be?

Should we check here if there is a closed_by user first? For ticket that were closed before this PR.

A few questions/suggestions but overall looks fine to me :)

Yes, or I could change the database migration to populate the closed_by user with the current Issue.user. What do you think ?

rebased onto dc55ef88985770ff36b1aaa6aa2c0402d6a6849d

Pretty please pagure-ci rebuild

Do we need the index here? (Not that I mind, but the alembic migration doesn't create it)

I think I would include the by in the if block and drop the else since the information is potentially wrong/confusing in this case

Couple of extra comments but it's looking good

ha no I don't think we need it, I forgot to remove it :)

rebased onto 65ba18f44ea5fe2e27da55443cb9ca504f220533

rebased onto 81c13058fc5a610339ac29316ccdd347f037ac72

Pull-Request has been merged by pingou

Metadata