pagure

#4121 PV endpoint: check score after the merge_status eval
Merged by pingou. Opened by fbo.
fbo/pagure cached_merged_status_unknown  into  master

Download 4121.patch

This change makes sure a PR got a merge status other than
'unknown' when minimal score to merge is set in the settings.
Indeed, if set, the score is checked first, and merge_status is
not set if score no reached. Even if the score is not reached
it makes sense to known the mergeability.

Can we have a test for this, or is this already covered by existing tests?

:thumbsup:

1 new commit added

  • Improve test for cached_merged_status when score activated

Pretty please pagure-ci rebuild

Looks fine to me, I'll rebase and run the tests, if they pass, let's get this in :)

I'm running into this error:
AttributeError: 'Response' object has no attribute 'get_json', I'll use the code we're using elsewhere

Commit 4c3ab2a0 fixes this pull-request

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.