I guess an import is missing:

import pagure.lib.model_base

Good catch

Consider to use debtcollector => https://docs.openstack.org/debtcollector/latest/reference/index.html#module-debtcollector.moves
Display a warning and inform users that this function has moved to an other module.

debtcollector cannot be used without triggering Pagure's license to change from GPLv2 to GPLv3, since OpenStack stuff is ASL 2.0.

Interesting lib, but it adds a new dependency :(

np :) I understand the license problem and the dependency adding

@bstinson looks like another one:
- console output show the test_style failed: https://ci.centos.org/job/pagure-pr/2095/console
- https://ci.centos.org/job/pagure-pr/2095/artifact/pagure/results-py2/py-test_style/view/ shows no error from this test
- https://ci.centos.org/job/pagure-pr/2095/artifact/pagure/results-py3/py-test_style/view/ shows no error from this test

:(

This passed CI last time, hopefully it will again :)

(if someone wants to formally approve/comment on it :))

Are you sure about this?
Since you have introduce these changes few days ago => https://pagure.io/pagure/c/6e566ade3b0907121b71d4c2c56b7e0d3169bf06?branch=master

I guess you need to rebase or something like that

:thumbsup:

👎

Yes, python black removed it though and since we have decoded the string earlier I thought we should be safe here now.

I'm ok with that :thumbsup:

Thanks, let's get this in then :)