AMPQ -> AMQP

@pingou Why aren't we ripping out legacy fedmsg for this?

@jcline Does fedora-messaging support arbitrary AMQP brokers? If so, how do we use that? Because it may make sense to expose that and just make that part of the "general AMQP support" for Pagure.

@pingou Why aren't we ripping out legacy fedmsg for this?

Backward compatibility :)

Would be a good idea for 6.0

@pingou We should mark the fedmsg integration as deprecated then, to warn of the planned removal and suggested migration strategy.

The P was pushed to the beginning of the line :-)

@ngompa : we have only tested the library with RabbitMQ, but I don't think it uses any rabbitmq-specific extensions on the consumer or producer level, so it may work with other brokers.

That said, fedora-messaging isn't aimed at being a general puropose AMQP library, there are other libraries for that in Python (pika, librabbitmq, etc). So I wouldn't say that this PR adds "general AMQP support".

ouspy :s

Why is this flipped? This looks like it will now exit and not publish a notification if it's True?

The default value is False, so this adjusts the code to the actual default value.

not True is False, so the function will not return and thus it will send the mqtt notification :)

This seems correct, do you feel like there should be unit tests for this?

This seems correct, do you feel like there should be unit tests for this?

Basically, we do not have tests for any of these messaging libraries, we should tackle them all in one go (let's open a ticket to track this).

Then it LGTM :-)

thanks :)

Ticket created at: https://pagure.io/pagure/issue/4242