#4247 Enable nosetests-2, nosetests-3 on CentOS-7
Closed by karsten. Opened by karsten.
karsten/pagure enable_nosetests_on_centos  into  master

Download 4247.patch

CentOS 7 doesn't have /usr/bin/nosetests-{2,3}, only /usr/bin/nosetests-{2.7,3.4}
Check if those exist and use them

Signed-off-by: Karsten Hopp karsten@redhat.com

This needs a careful inspection as nosetests-{2,3} on CentOS hasn't been run for a while:
10:22:47 which: no nosetests-2 in (/root/pagure/.tox/py27-flask011-ci/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin)
10:22:47 which: no nosetests-3 in (/root/pagure/.tox/py27-flask011-ci/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin)
...
10:24:54 No nosetests-2 found, removing python 2
10:24:54 No nosetests-3 found, removing python 3

1 new commit added

  • install nosetests

I don't think we want to proceed with this, on py2 nosetests is present and we do not test the py3 version on CentOS7, so there is no point having it.

I'll drop the run_ci_tests.sh script since it's no longer of use.

What do you think?

@pingou Could we just replace it with a file that lets you easily run the tests locally? Or at least some documentation on how to run them?

Also, do we need the nosetests and nosetests3 shims anymore?

@pingou Could we just replace it with a file that lets you easily run the tests locally? Or at least some documentation on how to run them?

Doc is definitely something we want/need

Also, do we need the nosetests and nosetests3 shims anymore?

I think these are safe to remove

Should we close this PR?

Pull-Request has been closed by karsten

Metadata