Looks good, it will need tests though :)

True, I will write them!

Results of the tests:
https://pastebin.com/9Zw6whgG

I have an impression that the def setup for my test function will not be generally liked, but I don't know if it's better to split it to the appropriate functions in the __init__.py module or better move it to the test_pagure_flask_api_fork.py inside the test_api_pull_request_user_token?

We'll need a more descriptive name :)

We already have methods to create projects as well as git repos and tokens, we should be able to just reuse them :)

hm, I'm only see changes to the test and to one default value in the configuration, is that expected?

hm, I'm only see changes to the test and to one default value in the configuration, is that expected?

yes, it is :)

We already have methods to create projects as well as git repos and tokens, we should be able to just reuse them :)

And how about the specific test just sets it's own resources? :) (I just wanted to make sure there are no interferences for this specific case)

And how about the specific test just sets it's own resources? :) (I just wanted to make sure there are no interferences for this specific case)

Doable but each run starts from a clean slate and just the setUp is called before the method, so up to you :)

Doable but each run starts from a clean slate and just the setUp is called before the method, so up to you :)

Ok, I will try to fit it into the init.py methods :)

branch: master
change: no, tests: no
expected: pass
actual: pass

branch: acls
change: yes, tests: yes
expected: pass
actual: pass

branch: master_acl_tests
change: no, tests: yes
expected: fail
actual: fail
failed tests: 1
failed test: test_api_pull_request_open_from_branch_to_origin
AssertionError: 401 != 200

I reused the methods for creating projects, repos and tokens and removed the setup_for_my_function thing.

Seems I broke 11 other tests with trying to fit it in already made methods :(

Only 1 test broken now..let's see if I can fix it. Hints very welcomed :)

test_pagure_lib.py is failing on master too

Looks good to me, thanks for adjusting the tests :)

If jenkins is happy, we'll get this in :)