PR#4306: Fix displaying diffs that contain symlinks. Fixes #4006 -

pagure

#4306 Fix displaying diffs that contain symlinks. Fixes #4006

Merged Feb 28, 2019 by pingou. Opened Feb 28, 2019 by bkabrda.

bkabrda/pagure fix-symlink-diffs into master

bkabrda commented Feb 28, 2019

Basically, the issue is that current code doesn't expect 40960 (0o120000), which is the code for symlinks. This PR fixes all ocurences of this problem - displaying headers for diffs with symlink on commit details page and also any page containing diffs (comparing two commits, displaying pull request).

Fixes #4006

pingou commented Feb 28, 2019

Code looks neat, thanks for fixing this.

Let's wait for jenkins and get this in :)

ngompa commented Feb 28, 2019

11:46:00  FAILED test: py3-test_pagure_flask_ui_repo

rebased onto dade63be547111d267254dace6c962343bb566df

Feb 28, 2019

ngompa commented Feb 28, 2019

:thumbsup:

Pull-Request has been merged by pingou

Feb 28, 2019

Metadata

Assignee

None

Tags

No Tags

pagure

#4306 Fix displaying diffs that contain symlinks. Fixes #4006 Merged Feb 28, 2019 by pingou. Opened Feb 28, 2019 by bkabrda. bkabrda/pagure fix-symlink-diffs into master

Metadata

#4306 Fix displaying diffs that contain symlinks. Fixes #4006

Merged Feb 28, 2019 by pingou. Opened Feb 28, 2019 by bkabrda.

bkabrda/pagure fix-symlink-diffs into master