pagure

#4382 Fix repoSpanner forking
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure repospanner_hook_fork  into  master

Download 4382.patch

Commit a9f8f56dc broke the ACL plugins when used via repoSpanner, because it would no longer send the internal flag, and the repospannerhookrunner was not updated to take the new internal_no_hook extra into account.

+1
Can that one be backported into 5.4 (not realeased yet, afaics) ?
We confirm that it currently affect the version deployed on src.stg.fedoraproject.org and git.stg.centos.org

Example or error message:

our task failed: Remote hook declined the push: Welcome to repoSpanner 0.5+2.9764a01d4983a6e19df68ba0d734fb708a6e06fe.el7.infra, node centos01.rpms.stg.fedoraproject.org Traceback (most recent call last): File "/tmp/repospanner_hook_runner_629055640/hookrun/pre-receive", line 72, in <module> pull_request, File "/usr/lib/python2.7/site-packages/pagure/hooks/__init__.py", line 355, in run_project_hooks repodir=repodir, File "/usr/lib/python2.7/site-packages/dist_git_auth.py", line 174, in check_acl user = get_user(session, username) File "/usr/lib/python2.7/site-packages/pagure/lib/query.py", line 131, in get_user raise pagure.exceptions.PagureException('No user "%s" found' % key) pagure.exceptions.PagureException: No user "pagure" found Hook returned error ERR Pre-receive hook refused push

Thanks !
Edited by pingou

Looks like one of the test needs to be adjusted:
File "/pagure/tests/test_pagure_repospanner.py", line 476, in test_hooks

AssertionError: u'Denied push for ref &#39;refs/heads/master&#39; for user &#39;foo&#39;' not found in  ...

No, this seems to be an error with the hooks being called in repoSpanner v0.5 on CentOS CI.
Just added a commit that should make it easier to determine what is going on.

1 new commit added

  • Print repoSpanner logs after test finishes

Grmbl at inconsistent error!

Thanks for the patch :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.