pagure

#4406 Add support for viewing and commiting to a utf-8 branch name
Merged by pingou. Opened by pingou.
fix_branch_unicode  into  master

Download 4406.patch
no initial comment

:thumbsup:

Looks fine for me ;)

:thumbsup:

I think I have a fix for the tests :)

5 new commits added

  • Add a test for viewing a branch named ☃️
  • Make the hook mechanism support utf-8 branch names
  • Some more indentation fixes in the HTML of repo_branches
  • Fix showing branches having unicode characters in their names
  • Adjust the indentation in the HTML of the repo_branches template

6 new commits added

  • Fix the sed command to run alembic in the tests in py2
  • Add a test for viewing a branch named ☃️ andensure it passes
  • Make the hook mechanism support utf-8 branch names
  • Some more indentation fixes in the HTML of repo_branches
  • Fix showing branches having unicode characters in their names
  • Adjust the indentation in the HTML of the repo_branches template

:thumbsup:

rebased onto c36e8b91fb741958fc3e499c14ceb2bb718321d3

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

1 new commit added

  • Move the pip env from python 3.4 to python 3.5

Ok, I'm going to go ahead and merge this one, I believe the last commit should fix the pip-based environment and the first two environment are passing their tests :)

Thanks for the review! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.