#4460 Make pagure work with recent sqlalchemy versions
Merged by pingou. Opened by pingou.
fix_sqlalchemy  into  master

Download 4460.patch

Fixes https://pagure.io/pagure/issue/4415

:thumbsup:

What's the impact of this change, performance wise?

Unknown at this time.

Tbh, I really dislike this solution :(

rebased onto 2bc92e7df80481d228f7ca104f595ae446f8a41f

Have you forwarded the breakage to SQLAlchemy upstream?

Have you forwarded the breakage to SQLAlchemy upstream?

Discussing with @puiterwijk he believes it's not a SQLAlchemy issue but a pagure one.

Our minimum version is still 0.8

rebased onto 0653ca2d65ff7a874ef149b34649cedfa5a0f4dd

This comment is not valid anymore with this change.

rebased onto 87c458e1c5bc591d0663fe27ce9171c8b8b2163a

rebased onto fefe88909a0f849891add3910a56f2dd6ff545c7

rebased onto df9b15c896dd702b70ce1602e792a32cb3269daf

:thumbsup:

Only one test failing...

11:44:34  Failed tests:
11:44:34  FAILED test: py-test_pagure_lib_git_auth

1 new commit added

  • Stop setting a backref on relations that are viewonly

:thumbsup:

As much as it pains me, let's get this in

Pull-Request has been merged by pingou

Metadata