pagure

#4502 vendor/highlightjs-line-numbers: better way to maintain our own downstream fork
Merged by pingou. Opened by jlanda.
jlanda/pagure highlightjs-line-numbers  into  master

Download 4502.patch

Right now we have an modified highlighjs-line-numbers minimified js included on pagure repo without any easy way to track our own changes and bump to upstream's fixes.

So I propose to create our own repository for this fork and specifiy on pagure the commit/tag from where the current minimized file comes from.

Downstream repo: https://pagure.io/pagure-highlightjs-line-numbers.js

Advantages:
- It's simpler to maintain our changes
- It's simpler to bump on upstream version
- Eventually we could automatize the generation of the minimified js and PR creation on main pagure repo when our highlightjs-line-numbers repo triggers it ;)
  • I would prefer moving the repo to some other namespace or without namespace and change this PR to reflect that.

Let's do w/o namespace since that's what we used here :)
I'll mirror the project on the pagure group in github as well ;-)

  • My repo and this PR are synced with the actual js version on pagure, but now is pretty easy to bump this to upstream's latest release, although I would prefer to do that a on different PR.

+1

Thanks for working on this!

rebased onto 2ac7442d6a1c8b2991e9f0432e99efab527d483e

PR updated

This script is a CSP problem right now, working on fixing that on the new repo

rebased onto 82bddd9708607cf7f4643d1bd2da6f902953ae65

rebased onto 5700ed436f9620003a29afd251e702317411c91d

Thanks for this, since it's not being tested anywhere by our test suite, I'm going to merge the PR without waiting on jenkins.

Thanks again :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.