there are two versions of the mail, one for keys with attached project and other one for the ones without it. Is correct to modify just the former?

@jlanda This seems like this might be specific to Fedora... Would it make sense to be able to pull this out into a template file that can be overridden for Fedora's deployments?

not with the current script. We would need a second script or including flask or at least jinga2 support to the script. The current implementation is an standalone .py script to be croned

It might worth using flask to generate proper urls for #4510 and btw we could add a theme macro to the template. That way we could maintain a clean upstream mail and add proper links for #4510 on both mail cases (api key with or without project)

This is actually fixing a ticket which I have closed as invalid: https://pagure.io/pagure/issue/4516
While informative, we can't patch pagure as is with this information as it is very specific to one particular instance of pagure and one tool interacting with it.

@pingou I didn't realize that there was a ticket :) I just spent a while trying to figure out wehre fedpkg hides the api key.

Perhaps this should be an infrastructure ticket to have our specific instance patched?

Ok, I've just received the following email:

Your Pagure API key flag commit linked to the project pagure
will expire in 1 day(s).
Please get a new key at: https://pagure.io/pagure/settings#apikeys-tab
for non-interrupted service.

coupled with the fact that one can now set the expiration time for an api token (up to 2 years), I think this improves the situation.

I will close this PR, we may still want to have this email be a template so it can be overridden, if someone wishes this feature, please open a dedicated ticket for it.

Thanks for your inputs!