#4554 Change - Update copyright byline based on current year
Closed 5 years ago by pingou. Opened 5 years ago by wattersmt.
Unknown source update_copyright  into  master

@@ -0,0 +1,3 @@

+ var year = new Date();

+ var copyright = "© 2014-" + year.getFullYear() + " Red Hat, Inc. and others.";

+ document.write(copyright);

@@ -42,7 +42,7 @@

                  </div>

              </div>

              <div class="d-flex justify-content-center align-items-center text-muted credit">

-                 <div>&copy; 2014-2019 Red Hat, Inc. and others.</div>

+                 <div><script src="{{ url_for('static', filename='copyright.js') }}"</script></div>

              </div>

          </div>

      </div>

@@ -47,7 +47,7 @@

                | <a href="https://docs.pagure.org/pagure/usage/index.html">Documentation</a>

                | <a href="/about">About</a>

              </p>

-             <p class="text-muted credit">&copy; 2014-2018 Red Hat, Inc. and others.</p>

+             <p class="text-muted credit"><script src="{{ url_for('static', filename='copyright.js') }}"</script></p>

          </div>

      </div>

  {% endmacro %}

@@ -58,7 +58,7 @@

                      </div>

                  </div>

                  <div class="ml-auto text-right">

-                     <div>&copy; 2014-2018 Red Hat, Inc. and others.</div>

+                     <div><script src="{{ url_for('static', filename='copyright.js') }}"</script></div>

                  </div>

              </div>

          </div>

@@ -102,7 +102,7 @@

                      </div>

                  </div>

                  <div class="ml-auto text-right">

-                     <div>&copy; 2014-2018 Red Hat, Inc. and others.</div>

+                     <div><script src="{{ url_for('static', filename='copyright.js') }}"</script></div>

                  </div>

              </div>

          </div>

The copyright byline will now be generated dynamically based on the current year.

Fixes #4522

rebased onto 77ce110

5 years ago

pretty please pagure-ci rebuild

5 years ago

Honestly I'm not fond of this, the copryright year should be updated at the first release of the year.
If it's so problematic to people that I've forgot to update it for a few months, then I'd just suggest we remove it.

Anyway, I am a bit inclined to close this PR without merging it

@pingou An alternative would be to just remove the year from the string. It's not required for these kinds of notices.

@ngompa Cf my comment ;-) (hint: the second sentence ;-))

I've updated the copyright year in the latest release, but I'm still considering just removing it entirely.

I'm going to close this PR for now, thanks for pinging me on this :)

Pull-Request has been closed by pingou

5 years ago