pagure

#4558 Ensure @ doesn't over-reach when sending notifications
Merged by pingou. Opened by pingou.
fix_user_notified  into  master

Download 4558.patch

If someone comments in a ticket or a PR with a text that contains an
email address, for example: foo@bar.com and the domain corresponds to an
existing username, we do not want to notify that user.
(Imagine if an gmail user gets created! :D)

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 55a1d5bd29bdc73e0d00a7703a5349c7c3503cba

rebased onto d77470ec36bfabadad893ac3bb0e77c8d9420140

rebased onto b16a15ba3ad3909d6dd12de3fd67383d94a17b33

rebased onto f42c03404b8d1ce09682b58f5eb16a044111dc5f

rebased onto e9aa55d907d677b7467f1b39d6629d084ba01294

pretty please pagure-ci rebuild

An email can have a number on their last character and \w will not capture it. pingou123@gmail.com will mention to gmail ?

rebased onto 4eb117fc175583ed18ac4d5ffe82615b3b36d782

New test added for bar123@foo.com :)

rebased onto fff28fb1358ea032a02de65988a37e56f86368c1

 
r"(?<![\w\-\"\'\`\$\!\*\+#%&/=^{}|~])@(\w+)"

This matches RFC5322 but could be too much, I never saw an email address with % or { on it's local part
Edited by jlanda

Let's be safe rather than sorry :)

rebased onto 3ff58428b20a037480b4dc5fd605c92a1675f02b

1 new commit added

  • Fix tests for new arrow version

:thumbsup:

:thumbs_up:

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.