pagure

#4613 UI: proper tag coloring
Merged by pingou. Opened by jlanda.
jlanda/pagure fix-tag-coloring  into  master

Download 4613.patch

Implements tag coloring jinga2 macro using it here and there
Fixes #4604

Rather than using jinja, shouldn't we just define the function in a .js file and call it where we want?

rebased onto bc513ac626c2bcf4f9762528be47953143108a74

rebased onto cc5555f8e68a2872133c985dd435ff452b71fcc1

js moves to .js file :D

I like this approach more.

I'm a bit surprised to see the .js include in some template where that code wasn't removed from.

rebased onto e89d842e4450e802e8b0487c9addf4d10ad726f0

I like this approach more.
I'm a bit surprised to see the .js include in some template where that code wasn't removed from.

Those views were hitting #4604 . I git grepped all the code looking for data-bg-color and following jinga2 inheritance|macro hierarchy now, I think that I caught all the tags on pagure, but could be someone more hiding somewhere that did not match my grep finding process =)

rebased onto 1177b475cfe4501819d87d67da36d2c8536676a5

Ok, thanks :)

Since this isn't covered in the tests, I'm going to get it in right now :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.