pagure

#4615 Some fixes on pull request ordering by Last Modified Date
Closed by jlanda. Opened by jlanda.
jlanda/pagure fix-pr-last-modified-order  into  master

Download 4615.patch

This is a proposal for fixing #4464

I continue without fully understanding the intent of these two modification-date related columns, so the updating logic around them could be totally wrong and need swaping updated variables on actions.

After this PR, right now:

The difference between last_updated and updated_on is on comments. Adding|editing comments does not update last_updated while adding metadata, flagging, assigning or modifying the pr itself updates both last_updated and updated_on

rebased onto 56c6163bb9ccb97c35e7f9dd7f7c51efb453b692

:thumbsup:

rebased onto 372d5f55fad7c34f68a18b6f54e915819415eb61

:thumbsup:

rebased onto dce0aa34617e37750da23eabf35d8e45fc5c8be0

rebased onto 78207a32618f942a769e278f90a7f20ec063854b

rebased onto d11596fab1fca0b08e32e8836bffd393cec024dc

rebased onto aed8012e955d0f996fe9d7040c77a2db18840e3e

rebased onto 1c4f5be328d94855220e5fab7c99d3ad1ebbd5bd

rebased onto 15fb308943bf99bd5034c6aae7b869d45229fdc8

pretty please pagure-ci rebuild

rebased onto 16c77667593356052a0cec8747851d24ce6130f7

:thumbsup:

pretty please pagure-ci rebuild

rebased onto 3f18f31424b16d6c4d6af8a0b280515227a3eb7b

rebased onto 36b427a0a6fc709a8f58629eaf2f1552666ccdc2

rebased onto ceb5a601ed339533e22bfbce0b77fb0f6c9c30b5

I've commented on the ticket, but this is not going to work, we do not want to sort/show the last_updated field.

I'll close this and work on the inverted way, my assumptions were all wrong as I suspected :smile:

Pull-Request has been closed by jlanda
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.