pagure

#4716 Add the file history feature
Merged by pingou. Opened by pingou.
file_history  into  master

Download 4716.patch

Fixes https://pagure.io/pagure/issue/1485

This still requires some tests, but early feedback welcome :)

@pingou could we have a screenshot too?

6 new commits added

  • Add unit-tests for the view file's history feature
  • Add a link to the file's history in the file's blame page
  • Add a link to the file's history in the file's view page
  • Add a new endpoint and page to see a file's history
  • Add a method to run git log using the system's git
  • Enable running a command in a specific folder and return the output

Here is one :)

Screenshot_from_2020-01-24_17-57-35.png

6 new commits added

  • Add unit-tests for the view file's history feature
  • Add a link to the file's history in the file's blame page
  • Add a link to the file's history in the file's view page
  • Add a new endpoint and page to see a file's history
  • Add a method to run git log using the system's git
  • Enable running a command in a specific folder and return the output

rebased onto b6f9a7b56d585e051261abe39b506a4b1a7026c8

Nice! Note that this PR would resolve #1485.

Maybe this is a tiny bit out of scope, but could we get a snippet of the commit message next to the commit hash (similar to GitHub and GitLab) in the blame view?

Also, a screenshot of file history view would be cool to see here. I assume that's a per-file variant of the commit view.

Also, a screenshot of file history view would be cool to see here. I assume that's a per-file variant of the commit view.

That's the screenshot I've put above

Oh! I thought we were looking at the blame view... I guess I expected it to look like the commit view?

rebased onto c074debcad00358d8db6a9b4603b2e1a98bca5fd

Here is the adjusted UI:
Screenshot_from_2020-01-24_18-29-28.png

rebased onto c899c272c4d392c9e0d2b826fd4e408e31cebf15

👌

rebased onto 5972bd88a5465e13038f41c4e0e1f81a56e4b7fb

7 new commits added

  • Rework the UI for the file history page
  • Add unit-tests for the view file's history feature
  • Add a link to the file's history in the file's blame page
  • Add a link to the file's history in the file's view page
  • Add a new endpoint and page to see a file's history
  • Add a method to run git log using the system's git
  • Enable running a command in a specific folder and return the output

7 new commits added

  • Rework the UI for the file history page
  • Add unit-tests for the view file's history feature
  • Add a link to the file's history in the file's blame page
  • Add a link to the file's history in the file's view page
  • Add a new endpoint and page to see a file's history
  • Add a method to run git log using the system's git
  • Enable running a command in a specific folder and return the output

:thumbsup:

Did not look the code yet, but looks great !

and the penguin? :p

Did not check all the js, but I wonder if we are actually using all the js on this view

Should we add username here for forks?

We should rely on one of the reopo's property instead you're right

And fix, this is not a tree view

tbh, I didn't check either :stuck_out_tongue:

7 new commits added

  • Rework the UI for the file history page
  • Add unit-tests for the view file's history feature
  • Add a link to the file's history in the file's blame page
  • Add a link to the file's history in the file's view page
  • Add a new endpoint and page to see a file's history
  • Add a method to run git log using the system's git
  • Enable running a command in a specific folder and return the output

Turns out most of the JS was not needed since there is no line numbering anymore.

:thumbsup:

:thumbsup:

Thanks for the review folks!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.