Did not test nor run test suite yet, so this could explode right now :)

Why are we forcing UTC? Is it because we don't have a timezone setting for pagure accounts?

Why are we forcing UTC? Is it because we don't have a timezone setting for pagure accounts?

DING.

Anyhow, my new filter calls timestamp filter. There is a comment on it:

    # We *could* enhance this by allowing users to specify preferred
    # timezone, localized time format etc. and customizing this display
    # to user's preferences. But we don't have that, so for now, we
    # always use UTC timezone, and we don't use localized forms like
    # %b or %d because they will be 'localized' for the *server*.
    # This format should be pretty 'locale-neutral'.

So if we fix this someday, the new humanize_tooltip will use it too

Sounds good to me. Let's see if the tests agree!

Looks like this is conflicting now :(

Looks like this is conflicting now :(

Luckily there was just one conflict. Rebased, I'll local test & align tests with the new html asap

test_pagure_flask_ui_fork.py errors should be fixed now (and they test that there is an span with a title btw)

\ó/

On python3 this shows up as "UTCs" does it do the same to you?

On python3 this shows up as "UTCs" does it do the same to you?

Good catch, the final s should not be there.

Fixed

And now tests check tooltip content :)

Hm if we check the issue list, the size of the font in the tooltip is different for the creation and the modification dates here. Do you see this as well?

Which makes me wonder if we shouldn't just change the date creation as there is no link there anyway (or re-use the same structure with data-tooltip in the filter)

Which makes me wonder if we shouldn't just change the date creation as there is no link there anyway (or re-use the same structure with data-tooltip in the filter)

data-tooltip thing enables boostrap styling. I added it to the filter, and now we have consistency on issues list. Anyway, we have a bunch of non timestamp related <span titiles without data-tooltip.

I'll open a ticket for that

====== 8 failed, 1634 passed, 7 skipped, 300 warnings in 1436.71 seconds =======

One of them is black (easyfix) the other one don't quite seem related to this PR but are also a tad worrying/annoying :(

Ok, no, so all the failing tests (but black) are related to the change made to MERGED_PATTERN

Thanks! :)