pagure

#4742 Hide the SSH clone URL if the user is not in one of the group with ssh access
Merged by pingou. Opened by pingou.
dist_git_improvements  into  master

Download 4742.patch

Some deployment of pagure have it set up in such a way that only the
members of certain groups can commit via SSH.
For this reason, there is not need to display the ssh url since they
cannot use it.

Fixes https://pagure.io/pagure-dist-git/issue/97

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • Drop un-used import

I'm not happy with the filter name. We are just restricting ssh commits and not http ones and this can be missinterpreted. user_group_can_ssh_commit or something? I'm not the best name creator, but imo the filter name should reflect that this is just about ssh access and http one is not affected :D

I don't see where are you using result . We could just all call add_user_to_group without storing the result

user_group_can_ssh_commit works for me :)

:thumbsup:

wfm except the two little comments =)

rebased onto 6690c75ba19e09e897c62dfb9750f481fd645c10

:thumbsup:

Jenkins is happy.

Thanks for the review!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.