@pingou typo in commit message: remotly -> remotely

@pingou typo in commit message: remotly -> remotely

Fixed, thanks

@pingou should we be concerned that this is a fully synchronous API call, as opposed to something that is handled in a celery queue?

(This is also partly a broader question about a lot of our APIs...)

@pingou should we be concerned that this is a fully synchronous API call, as opposed to something that is handled in a celery queue?

I'm not seeing anything that would concern me, what do you have in mind?

you have my :thumbsup: if jenkins is happy :)

:thumbsup:

@pingou My general concern is that I don't want the API being hammered by automation in such a way that the frontend gets knocked out regularly during high numbers of builds in parallel.

Your fear DDoS by API calls, this is plausible and would affect every endpoints, not just this one indeed.

I don't really like the idea of moving this to be async, or we make it optional maybe?

@pingou I think we need a way to optionally make API calls handled async, as unpleasant as it sounds. But this PR in itself is fine as-is. The work to do that can be done separately.

Thanks for the review folks

@ngompa I agree, we may want to consider having the API be async on demand, but we can do this in a separate PR.