PR#4785: Do not block when waiting for subprocess to finish -

pagure

#4785 Do not block when waiting for subprocess to finish

Merged Mar 29, 2020 by pingou. Opened Mar 26, 2020 by msrb.

msrb/pagure comm-and-wait into master

msrb commented Mar 26, 2020

If the subprocess generates enough output to fill up the pipe, it will
block and wait for somebody to read from the pipe before continuing.

Signed-off-by: Michal Srb michal@redhat.com

msrb commented Mar 26, 2020

The problem is also described in the official docs: https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait

ngompa commented Mar 26, 2020

:thumbsup:

pingou commented Mar 26, 2020

Thanks for catching this!

pingou commented Mar 27, 2020

Looks like this is the change black would do:

diff --git a/ tests/test_pagure_lib_git.py b/ tests/test_pagure_lib_git.py
index 64ed6927c..3e67d42e4 100644
--- a/ tests/test_pagure_lib_git.py     
+++ b/ tests/test_pagure_lib_git.py     
@@ -3173,10 +3173,7 @@ index 0000000..60f7480
         here = os.path.dirname(os.path.realpath(__file__))
         # This should't block
         self.assertTrue(
-            pagure.lib.git.read_output(
-                ["git", "rev-list", "--all"],
-                here
-            )
+            pagure.lib.git.read_output(["git", "rev-list", "--all"], here)

Could you do it?
Otherwise, I can do it locally and push it via another PR to have CI run on it and close the two PR in one go.

pingou commented Mar 29, 2020

Commit 6db5a5b9 fixes this pull-request

Pull-Request has been merged by pingou

Mar 29, 2020

Metadata

Assignee

None

Tags

No Tags

pagure

#4785 Do not block when waiting for subprocess to finish Merged Mar 29, 2020 by pingou. Opened Mar 26, 2020 by msrb. msrb/pagure comm-and-wait into master

Metadata

#4785 Do not block when waiting for subprocess to finish

Merged Mar 29, 2020 by pingou. Opened Mar 26, 2020 by msrb.

msrb/pagure comm-and-wait into master