pagure

#4951 Fix line numbering on pull requests
Merged by pingou. Opened by jlanda.
jlanda/pagure fix-pr-diff-line-number  into  master

Download 4951.patch

Fixes #724

And this looks like pr_diff_numbers.png

rebased onto b9a6f7868a93962888822793c9d9760d4106e989

:thumbsup:

Anyway we could test this?

Anyway we could test this?

Sure.

Should I remove the line numbers from the '@@' line too?

rebased onto ca304b8fd054f7de3fb7d0560392ea4a12812129

the format_loc() filter is used just on _diff_pull_request.html template, so I went with some cleaning on the way.

let see what folks and jenkins says about it :)

(I'll squash this)

diff.png
Edited by jlanda

Seems like tons of wrong assumptions on my side, i love it :D

rebased onto cbeb61ea50c2de795cfa707b218cbf138aa35796

5 new commits added

  • black formatting & tests
  • add line numbers on diff lines, but not on @@ line. remove add comment link on @@ line.
  • no need to check this on every line
  • we always have a valid index here
  • remove isprdiff option on format_loc filter

1 new commit added

  • fix black's dumbness

Now with tests! let me no if I have to squash them

1 new commit added

  • split long line

7 new commits added

  • split long lines
  • fix black's dumbness
  • black formatting & tests
  • add line numbers on diff lines, but not on @@ line. remove add comment link on @@ line.
  • no need to check this on every line
  • we always have a valid index here
  • remove isprdiff option on format_loc filter

@jlanda squashing would be appreciated :smile:

done =)

rebased onto 2a722ba5fe941202eb9e48964090b277e297b5a4

:thumbsup:

rebased onto 3bef580e2a562be2b88bf762f0490da1cbcd8867

rebased onto 8e3ae652aaa105fcd420668b9e5c07753d1f33f0

Tested locally and loving it!

Many many thanks!!

Pull-Request has been merged by pingou

Many many thanks!!

You're welcome :)
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.