#4974 Improve the design of the top app bars of Pagure
Closed by ryanlerch. Opened by appadeia.
appadeia/pagure cblack/responsive  into  master

Download 4974.patch

This improves the styling of Pagure's top app bars by:

  • Flattening the secondary tabs found in repos into a single mobile-friendly hierarchy
  • Making them responsive
  • Moving the repo top app bar to the bottom on mobile for reachability
  • Shedding excess iconography

Before:
Desktop:
desktop before
Mobile:
mobile before

After:
Desktop:
desktop after
Mobile:
mobile after

Signed-off-by: Carson Black uhhadd@gmail.com

@appadeia Shouldn't the arrow in Open PR and Clone be flipped when it's on the bottom?

rebased onto 342f1824e14a5ca8193c5602134524611344dfb5

@appadeia Shouldn't the arrow in Open PR and Clone be flipped when it's on the bottom?

Done.

I like the mobile view, but I miss the icons in the new versions. Are they that bad?

I like the mobile view, but I miss the icons in the new versions. Are they that bad?

They're not really informative since icons are best at metaphors, but git concepts are highly abstract and hard to make a metaphor for.

Additionally, they cause the bottom bar to exceed common mobile screen sizes.

@appadeia can we keep the icons in the regular view, but in mobile/compressed views, drop the icons?

@appadeia can we keep the icons in the regular view, but in mobile/compressed views, drop the icons?

Icons work best when they're extremely common and use well known metaphors. Icons for git stuff aren't extremely common and don't really use a metaphor to help you understand the content, which defeats their functional point.

I like the secondary navigation for Desktop. It makes navigation less overloaded than in GitHub.

I would change the navigation style. In my opinion it is better to visit a platform where you can hire professional app designers. I'm sure they will find ways to make the app even more user-friendly and visually appealing, because great design is the key to success.

@ngompa consider and improving for Pagure 6 or closing?

Let's try to improve for Pagure 6.

This project has moved to https://forge.fedoraproject.org/apps/pagure. As part of the migration, all open pull requests on pagure.io have been closed. If you'd like to continue working on this, please fork the repository on the new forge and re-submit your PR there.

Pull-Request has been closed by ryanlerch

Metadata