pagure

Clone

#5001 Encode the data passed onto the mail hook so it is of bytes type
Merged 4 years ago by pingou. Opened 4 years ago by pingou.
fix_email  into  master

file modified
+1 -1 
@@ -1593,7 +1593,7 @@ 
 

      weeks_range = flask.request.args.get("weeks_range") or 53
 

      try:
 

          weeks_range = int(weeks_range)
 

-     except:
 

+     except Exception:
 

          weeks_range = 53
 

  

      repo = _get_repo(repo, username, namespace)

file modified
+1 -1 
@@ -128,7 +128,7 @@ 
 

          proc = subprocess.Popen(
 

              [hook_file], cwd=repodir, stdin=subprocess.PIPE
 

          )
 

-         proc.communicate(stdin)
 

+         proc.communicate(stdin.encode())
 

          ecode = proc.wait()
 

          if ecode != 0:
 

              print("git_multimail failed")

Fixes https://pagure.io/pagure/issue/4999

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

:thumbsup:

rebased onto 7da742e5b72950185f3f3a8e679a3733d3d84662
4 years ago

pretty please pagure-ci rebuild
4 years ago

pretty please pagure-ci rebuild
4 years ago

rebased onto e02fcc0
4 years ago

pretty please pagure-ci rebuild
4 years ago

:thumbsup:

Thanks! :)

Pull-Request has been merged by pingou
4 years ago
Changes Summary 2
+1 -1
file changed
pagure/api/issue.py
+1 -1
file changed
pagure/hooks/mail.py
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.