Should also the USER schema at pagure-messages be updates? Which one should be done first?

Should also the [USER schema at pagure-messages][schema] be updates? Which one should be done first?

Yes the schema should be updated, we can do the change in the payload first
since we're adding to it, so it won't break the existing schemas

You can drop the .keys() here, it's actually making python slower: http://blog.pingoured.fr/index.php?post/2012/03/12/Python-notes-to-self

Should also the [USER schema at pagure-messages][schema] be updates? Which one should be done first?

Yes the schema should be updated, we can do the change in the payload first
since we're adding to it, so it won't break the existing schemas

Schema update: pagure-messages pull request 6

.keys() dropped.

I actually like the proposed changes and think this one and https://pagure.io/pagure-messages/pull-request/6 should be merged. It looks like that I can't rebase this PR to run the unit tests. @ngompa can you rebase? If not, do you want me to create a fresh PR based on the patches?
Btw I learned this week about Fedora Badges and think we should also work to get https://pagure.io/fedora-badges/pull-request/806 reverted and Pagure badges back ;)

This pull request has conflicts, I cannot rebase it. I think a new pull request will need to be made.

I (technically) fixed the conflict and pushed. However, there are still some unsolved problems:

First, some test data initialization errors about KeyError: refs/heads/main when running Tox on Python 3.12 environment locally. It has a single line quick fix, which I did not sanity check properly yet. Probably all test code should switch to default branch name main, or test support code should stop assuming master branch being the default head. Something like that.

Second, there seems to be some confusion about the meaning of first and last element in the revs list given to send_notifications(). The code that produces start_commit and end_commit in the notification assumes the final commit is the first element, while the code that produces changed_files assumes the final commit is the last element. It looks like a bug to me (ping @nforro as the author of the changed files code, which was added last).

This project has moved to https://forge.fedoraproject.org/apps/pagure. As part of the migration, all open pull requests on pagure.io have been closed. If you'd like to continue working on this, please fork the repository on the new forge and re-submit your PR there.