#5363 fix(theme): long words in source nav break layout
Merged by ngompa. Opened by wombelix.
wombelix/pagure fix_long_words_in_source_nav_break_layout  into  master

Download 5363.patch

template 'commit.html' didn't limited the width of the nav colum, the src.fp.o theme adds additional information which might contain long words which then broke the layout, the content appeared below the side navigation. To fix this, a text break will be enforced in the relevant div as well.

Fixes: https://pagure.io/pagure/issue/5353

See related issue for further details and screenshots, solution need to be discussed before merged, the PR just demonstrate a potential workaround.

Have you tested this fix with all included themes?

rebased onto fbbcd24bed58a7340b083ae95cb875c0d7599abf

rebased onto c9bd2f2751306979f1523dab442e1e5b2bb903c7

Have you tested this fix with all included themes?

Yes I did, the only global change is in commit.html and actually just aligns it with other templates like commits.html. Instead of allowing the left side to consume more then two colums, we limit it to two columns as on every other page.

The most relevant changes are only in scope of the srcfpo theme files.

Pull-Request has been merged by ngompa

Metadata