#5381 [WIP][feature] Enable collaborators to merge the PR(s)
Closed by ngompa. Opened by jnsamyak.
jnsamyak/pagure ft/enable-collaborators-to-merge-prs  into  master

Download 5381.patch

This PR enables collaborators to merge, while not restricting the people with committer access to merge the pull request.
Please refer to this issue for the relevant request/use-case reference.

Ugh, the CI is failing because somehow all the old Fedora release tags for the container image at quay.io were deleted. :frowning:

pretty please pagure-ci rebuild

rebased onto ab6c0422609330388e0f4c309c34c64f40dcb710

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

@jnsamyak Could you take a look at the test failures? https://jenkins-pagure.apps.ocp.cloud.ci.centos.org/job/pull-requests/137/console

On my todos for this week, hopefully will get a workaround to it :D

rebased onto 22afe7823663c5b803b988562d287c4d42aba980

rebased onto f2532dbc444f7b27def56c6d3d6fa3869bcfaf24

rebased onto 3f5af2c4284f13d4c317d059d8f41838b026b286

Looks like you're just outside the {% if g.authenticated ... check from line 138, here (it closed on line 164), so you'd have to check again before using g.fas_user.

Suggestion:

{% if g.authenticated and (g.repo_committer or g.fas_user.username in g.repo.collaborators) %}

Superseded by #5438

Pull-Request has been closed by ngompa

Metadata