pagure

#5437 Support Redis Unix sockets
Merged by ngompa. Opened by crameleon.
crameleon/pagure redis-socket  into  master

Download 5437.patch

Introduce a configuration option "REDIS_SOCKET", allowing the path to a Unix socket to be specified as an alternative to the
existing, TCP/IP based, "REDIS_HOST"/"REDIS_PORT" options.

Signed-off-by: Georg Pfuetzenreuter mail@georg-pfuetzenreuter.net

This looks great, but it looks like there are three test failures, could you look at fixing them?

23:20:46  FAILED tests/test_pagure_lib.py::PagureLibtests::test_set_redis - TypeError: ...
23:20:46  FAILED tests/test_style.py::TestStyle::test_code_with_black - AssertionError:...
23:20:46  FAILED tests/test_style.py::TestStyle::test_code_with_flake8 - AssertionError...

Full log here: https://jenkins-pagure.apps.ocp.cloud.ci.centos.org/job/pull-requests/227/consoleFull

rebased onto 45d7f4bd6f315c2a0b0a0a770fdae6aa1f7c466f

pretty please pagure-ci rebuild

Thanks, I think I repaired it, but where do I find the new output from here?

Can you rebase your pull request? Then it should start running the tests and you'll see it show up as a flag in the message log here.

There is nothing to rebase, my branch is up to date with master.

rebased onto 537165786764fb2076790e349ddc293aa499d1ab

Aha, now. :)

rebased onto 3cc41cc52cd995cfa48c46a6158fdc46f0d3db4f

rebased onto f27692f0aa356645fb5bdc7d99b32e611ee2271c

This does not sound like something related to my patch?

17:34:44  E                       pkg_resources.DistributionNotFound: The 'zope-interface>=5' distribution was not found and is required by Twisted

No, it's not related, don't worry about it. :weary:

@crameleon Can you please rebase this again so I can merge this?

rebased onto c15e7251f70b2280e272698183c10554da02d3aa

Pull-Request has been merged by ngompa

Merged, thanks for the patch!
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.