These changes are making the issue page be a large form as it was before the new UI change.

This allows making multiple changes at once (for example changing the assignee and adding a comment) and more importantly it allows updating the issue page correctly via SSE.

Before that, there were two forms of which only one of them was correctly updated by the SSE
meaning, if you assigned a ticket to someone, then add a comment (without reloading the page since the SSE takes care of updating it), then adding the comment would wipe out all the change you had made to the metadata.

/cc'ing @ryanlerch for his thoughts :)

Fixes https://pagure.io/pagure/issue/819

Yeah, i think i split this up before I knew that SSE was being used.

My biggest reason for spliting it up was that they are really located in two different places, now (before the metadata was down near the comments IIRC), but SSE kinda makes this moot.

so :thumbsup: from me from a conceptual point of view. (i.e. not a code review thumbs up)

Thanks @ryanlerch :)

Why jQuery and not $()?

No good reason :)

Perhaps instead of looking in , look for the ID of the form or classes of forms?
Since this might also enable new forms you add later on for other tasks.

One last comment, otherwise +1

We block all submit button at the start so I think it's just fair that we enable them at the end.

Right, but this might inadvertently enable the submit button for new forms you might add in the headeror footer or sidebar.
If you think that's not going to happen, or you'll take care of it when it does, that's fine with me.

Ack

Thanks