I'm still seeing the rounded corners only on one side of the fork button even after moving the csrf_token part. The reason this is happening is that (not sure why i did this), is that parent div of the button has the btn-group class applied to it (line 6 of this patch). If you remove that class, it the corners are rounded on all sides of the button
Thanks for the PR!
Just wondering what the changes to the pagure.css are fixing? Just setting the select to docs should make it work properly.
Thanks for the PR! Just wondering what the changes to the pagure.css are fixing? Just setting the select to docs should make it work properly.
Oh, i see what is happening now. the changes to pagure.css are fixing the gap that is showing up under the now active docs tab.
This is because the "Open in new Tab" link on the right of the menu bar doesnt have the right class added to it. If you add the "nav-link" class to the <a> element here:
https://pagure.io/pagure/blob/master/f/pagure/templates/repo_master.html#_195
that will fix the issue rather than adding an additional css rule.
:thumbsup: on keeping the csrf token where it was :)
Pull-Request has been rebased
Thanks Ryan, your suggestions make a much better correction. I have changed and rebased.
Looks good to me.
I'll let @ryanlerch do the merging if he is satisfied as well.
@pvl thanks!
looks perfect now!
Pull-Request has been merged by ryanlerch