#874 Updates to priorities for issues
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure priority  into  priority

Download 874.patch
no initial comment

adds:

  • sorting to priorities for issues
  • new styles for the priority editing in repo settings

Pull-Request has been updated

one thing i noticed while playing around with the stuff in the settings: if you manualy enter in a new prioroty that has the same weight as an existing one, it overwrites the existing one -- we really should check this and warn the user.

We need to split this line, it's too long :(

I see you're doing the sorting in JS, it's an idea, mine was to do it at the DB level, but doing it in JS might allow us to sort different fields (authors, attributee, ids...)

one thing i noticed while playing around with the stuff in the settings: if you manualy enter in a new prioroty that has the same weight as an existing one, it overwrites the existing one -- we really should check this and warn the user.

:thumbsup: good catch

Pull-Request has been updated

updated the PR to split the long line out into 3 lines

I'm gong to merge it as is, but I wonder if we should add a little sign saying that clicking on the title allows sorting, that or make the behavior consistent with the other columns if we can.

Food for thoughts :)

Thanks a lot @ryanlerch!

Note: this breaks again the test suite :)

I'll fix it

Pull-Request has been merged by pingou

Metadata