#875 Improve description git hooks
Merged by pingou. Opened by lsedlar.
lsedlar/pagure hook-description  into  master

Download 875.patch
no initial comment

First commit fixes some typos, the second expands the description of pagure hook.

Should we include the list of keyword supported or a couple of examples?

One question otherwise looks good, thanks!

Originally I wanted to include that, but looking at the supported keywords and formats I could not find a nice way to describe it. I will try to find some way to add that.

Originally I wanted to include that, but looking at the supported keywords and formats I could not find a nice way to describe it. I will try to find some way to add that.

Thanks for that :)

Pull-Request has been rebased

I have changed the description to be even more verbose. Also, I have enabled using Markdown for the descriptions. I don't see any way in which it might cause problems, but I may be wrong. Alternatively HTML could be used directly, but I think some sort of fine-grained method of formatting is needed.

The last commit changes the order of plugins: they are alphabetically sorted.

Just to be sure, are the tests passing fine?

Otherwise it looks good to me! :)

Pull-Request has been updated

They do now. Thanks for reminder.

Thanks for fixing them :)

Merging!

Pull-Request has been merged by pingou

Metadata