#879 show tagnames of lightweight tags in releases
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure releases  into  master

Download 879.patch
no initial comment

Because lightweight tags are simply just a marker to a particuair reference in the GIT repo, libgit2 just returns a Commit object rather than a Tag object. Because of how we were showing this, this caused lightweight tags to not show tagnames in the releases list.

In the case of a lightweight tag, This patch adds the name of the tag to a list that is sent to the template, and the template now shows the lightweight tagnames in the releases page

Pull-Request has been updated

Knowing the hash of a tag seems useful to me, do we want to keep the info?

Maybe instead of making a list of a list, we should make a list of dict?

Pull-Request has been updated

Sorry, this turned into a bigger play around with the releases page.

I have extended this PR, and it now reorganizes and restyles the releases list, as well as adding a feature to download a tar based on the ref for the release.

Could we keep the tar feature out of this for now? I'd like to test it separately (how does it behave with the kernel tree? does it generate a new sha1 everytime? can/should we cache the tarball on disk?)

Pull-Request has been updated

Could we keep the tar feature out of this for now? I'd like to test it separately (how does it behave with the kernel tree? does it generate a new sha1 everytime? can/should we cache the tarball on disk?)

Done, sorry, got a bit sidetracked with that one. :) the tar stuff is now in a seperate branch in my fork

And what do you think of this?

Pull-Request has been updated

Okies, updated this to be a lot cleaner and hopefully easier to read code-wise.

Also, the hash was still included, it was just on one of my long lines :)

Also, i know the tests are broke, just want to make sure you are happy with how I have implemented this before fixing the tests

Oupsy :)

here as well :)

Code wise it looks really good, nice work :)

Pull-Request has been rebased

Pull-Request has been updated

Pull-Request has been updated

Pull-Request has been updated

Pull-Request has been updated

Okies, removed the extra print statements that I left in accidentially, fixed a few typos of variable names, and fixed the tests.

Pull-Request has been rebased

Pull-Request has been merged by pingou

Metadata