Pull-Request has been rebased
Could you add a test with a request where the user is logged in? I think this triggers a bug for me :)
rebased
Added. It passes the test. :)
Ok, seems to work great with one little curiosity:
if I diff aaa..bbb, I see two commits, aaa then bbb (one being after the other)
if I diff aaa..ccc, I still see only two commits, aaa and ccc, while I would expect to see aaa, bbb, and ccc.
If that expected?
2 new commits added
That will have to be adjusted :)
(same for the file name please)
Do you need more help from me?
I was troubleshooting the problem the last day we talked, but had'nt enough time to put both hands on it. Next week will fix it. If I need more help will message you at IRC
Thanks :)
Thanks for the update, I'll ping you again next week then :)
From my tests it looks fine
I did the follow diff aaa..bbb
then did the diff aaa..ccc
Seems to mimick what git does in the CLI
Looks good to me :)
Let me know if you're also happy with this and let's merge it :)
(PS: we'll need to rebase first though)
Ok. Will PEP8 the test part and rebase it so we can merge it. If i don't have time today, will do it on monday morning.
Thanks and have a nice weekend
Thanks, you to :)
Looking forward for the rebase :)
Now the pull request is ready for merge. Fixed PEP8 styling in test and re-check of tests passing.
Pull-Request has been merged by pingou