@pingou, The pull-request button background was looking a bit odd on hover. So fixed it. Also the problem I was facing in issues page when using google chrome has been fixed.
I had to google a little to fully understand this syntax, which makes me a little chily to merge this.
Could you see if it can be transformed to a more regular if statement?
Thanks, the rest looks good :)
Seems like there was a typo in that line. Anyways Changed it to simple if else statement.
On Fri, Apr 10, 2015 at 8:50 AM, pagure@pagure.dev.fedoraproject.org wrote:
Project: pagure pingou commented on the pull-request: Changing the way default parameter is assigned, so as to make it run across different browser that you are following. New comment: `` I had to google a little to fully understand this syntax, which makes me a little chily to merge this. Could you see if it can be transformed to a more regular if statement? Thanks, the rest looks good :) `` http://pagure.dev.fedoraproject.org/pagure/pull-request/92
Project: pagure
pingou commented on the pull-request: Changing the way default parameter is assigned, so as to make it run across different browser that you are following.
Changing the way default parameter is assigned, so as to make it run across different browser
New comment:
`` I had to google a little to fully understand this syntax, which makes me a little chily to merge this.
Thanks, the rest looks good :) ``
http://pagure.dev.fedoraproject.org/pagure/pull-request/92
Oops. I forgot to delete the thread. @pingou , I would like to make a feature request of having a 'delete' or 'edit' button for comments.
+1 for the delete/edit (feel free to open two tickets for this) I also would like to find a way to automatically clean the email in some cases (like here for example, if all the line starts with > drop the section or so)
>
Regarding the PR, thanks for your work!