#1 Add ability to read configuration from /etc/security/faillock.conf
Merged by tmraz. Opened by rga.
https://github.com/redhatrises/pam-redhat/ master

Download 1.patch

Adds the capability for pam_faillock to read from /etc/security/faillock.conf (#1537242)

rebased onto f045e6783ab4f1a2d40f1309314995457b7c0009

bump @tmraz

This is superfluous paragraph. Should not be there as it is in the pam_faillock manpage. On the other hand there should be a simple sentence saying something about the faillock.conf configuration file.

This section should not be here at all. Or there should be at most some reference to the pam_faillock page.

Again, this section is not needed or at most there should be example of the faillock.conf file and reference to the pam_faillock manpage.

I'd probably use something like: The support for faillock.conf was written by Brian Ward.

You should not drop the options from the manual page. At least not from here.

You can drop the option description from here and you can also write here something about using the options on module command line is not recommended and faillock.conf should be used instead.

Do not drop this paragraph from here. You can adjust it to mention faillock.conf. I.E. "...using the module in preauth without the silent option specified in faillock.conf or with....."

Please keep the support for the options on module command line. This is absolutely necessary for backwards compatibility.

rebased onto f0202889c9745e680123d835fda65ea203430118

rebased onto 30135d362da215339fe0cedb878942189db0b864

1 new commit added

  • Add faillock.conf

@tmraz updated the PR with your suggestions. Also, added a commit that adds faillock.conf.

Copy & paste error from pwquality.conf documentation.

Better would be: "configure the default settings for locking the user after multiple failed authentication attempts."
Or something similar.

3 new commits added

  • Fix typos and update descriptions
  • Add faillock.conf
  • Adds the capability for pam_faillock to read from /etc/security/faillock.conf (#1537242)

Copy & paste error from pwquality.conf documentation.

sigh.... definitely was a brain copy/paste

Better would be: "configure the default settings for locking the user after multiple failed authentication attempts."

@tmraz this is definitely better. Fixed.

A spurious character here?

3 new commits added

  • Fix typos and update descriptions
  • Add faillock.conf
  • Adds the capability for pam_faillock to read from /etc/security/faillock.conf (#1537242)

A spurious character here?

Unfortunately yes. Fixed.

Pull-Request has been merged by tmraz

Merged, thank you.

Metadata