#13 Approving requests does not respect waiting-for-approval state
Closed: Fixed Opened by ppisar.

''psabata'' requested for ''commit'' and ''approveacls'' only in ''f16'':

{{{
$ pkgdb-cli.py acl --pending perl-Business-CreditCard all
Fedora Package Database -- perl-Business-CreditCard
Validate/generate credit card checksums/names
0 bugs open (new, assigned, needinfo)
devel Owner: orphan
watchbugzilla watchcommits commit approveacls
Group:
Comaintainer(s):
f16 Owner: ppisar
watchbugzilla watchcommits commit approveacls
Group:
Comaintainer(s):
psabata Awaiting Review Awaiting Review
}}}

but ''update --approve ... all ... '' switch not requested permissions too:

{{{
$ pkgdb-cli.py update --approve perl-Business-CreditCard all psabata f16
Password:
watchbugzilla Approved for psabata on package perl-Business-CreditCard branch f16
watchcommits Approved for psabata on package perl-Business-CreditCard branch f16
commit Approved for psabata on package perl-Business-CreditCard branch f16
approveacls Approved for psabata on package perl-Business-CreditCard branch f16
}}}

I think the approve action should take effect on pending permissions only.


It could use some more testing, but should be working from:
https://fedorahosted.org/packagedb-cli/changeset/2eb663eaeaaee2c4086cd63d45de0dfdca14a733

Thanks for the report.

I verified it works now as I expect. Thank you.

Then I close the ticket. Thanks!

Metadata