pungi

#590 ostree repo_from option should not be required
Closed: Fixed Opened by ausil.

Closed: Fixed
Reopen Issue

Given the following config which is intended to build an ostree from a repo only it fails to validate

# PRODUCT INFO
release_name = 'Atomic-cd'
release_short = 'FACD'
release_version = 'Rawhide'
release_is_layered = False
# GENERAL SETTINGS
bootable = False
variants_file='variants-fedora.xml'
sigkeys = [None]
# limit tree architectures
# if undefined, all architectures from variants.xml will be included
tree_arches = ['aarch64', 'armhfp', 'ppc64le', 'x86_64']
# limit tree variants
# if undefined, all variants from variants.xml will be included
tree_variants = ['Atomic']
hashed_directories = True
# RUNROOT settings
runroot = True
runroot_channel = 'compose'
runroot_tag = 'f27-build'
createrepo_checksum = 'sha256'
# PKGSET
pkgset_source = 'koji' 
pkgset_koji_tag = 'f27'
gather_source = 'none'
gather_method = 'deps'
koji_profile = 'compose_koji'
ostree = [
    ("^Atomic$", {
        "*": {
            "treefile": "fedora-atomic-docker-host.json",
            "config_url": "https://pagure.io/fedora-atomic.git",
            "repo": [
                {
                    "name": "buildroot",
                    "baseurl": "https://kojipkgs.fedoraproject.org/repos/rawhide/latest/$arch/",
                    "gpgcheck": False
                },
            ],
            "ostree_repo": "/mnt/koji/atomic-cd/",
            'failable': ['*'],
        },
    }),
    ("^ostree$", {
        "x86_64": {
            "treefile": "fedora-ostree-workstation.json",
            "config_url": "https://pagure.io/workstation-ostree-config.git",
            "repo": [
                {
                    "name": "buildroot",
                    "baseurl": "https://kojipkgs.fedoraproject.org/repos/rawhide/latest/$arch/",
                    "gpgcheck": False
                },
            ],
            "ostree_repo": "/mnt/koji/atomic-cd/",
            'failable': ['*'],
        }
    })
]

Failed validation in ostree.0.1.*: 'repo_from' is a required property
Failed validation in ostree.1.1.x86_64: 'repo_from' is a required property

there is no variant in the compose to use for repo_from it should not be required

'repo_from' has been deprecated by https://pagure.io/pungi/pull-request/581 (merged but not released yet), so now only 'repo' is required, you can add repo dicts in repo values just like above, and variant uid, repo url are supported too, if run with old config file which contains 'repo_from', the value will be appended to 'repo' automatically.

You can not use a http url in repo_from, you get a key error and you can not in 4.1.14 leave it empty or undefined.

You can not use a http url in repo_from, you get a key error and you can not in 4.1.14 leave it empty or undefined.

Yes, repo_from only supports variant UID, when new package released with #581, you can just use repo which supports variant UID, url and a dict that at least contains baseurl.

This should be fixed in 4.1.15. The config still does not validate because for some reason "gpgcheck" should be a string (which is probably a bug). Since it's disabled by default, the option can just be dropped in should work.

Metadata Update from @lsedlar:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
- Issue tagged with: 4.1.16

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/pungi/pungi/issues/590

Please continue any further discussion there.
Metadata
None

4.1.16

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.