PR#1831: Recognize tar archive type in Koji - pungi

pungi

#1831 Recognize tar archive type in Koji

Opened a month ago by lsedlar. Modified 7 days ago

lsedlar/pungi tar-image-type into master

osbuild: Add a hack to detect wsl images

Lubomír Sedlář • 8 days ago

f7cfa1d

Recognize tar archive type in Koji

Lubomír Sedlář • 8 days ago

7e201b2

pungi/phases/osbuild.py

file modified

+5 -1

		`@@ -19,6 +19,7 @@`
		`{`
		`"iso": ["iso"],`
		`"vhd-compressed": ["vhd.gz", "vhd.xz"],`
		`+ "tar": ["tar", "tar.gz", "tar.bz2", "tar.xz", "tgz"],`
		`}`
		`)`

		`@@ -269,7 +270,10 @@`
		`# determine the manifest type based on the koji output`
		`img.type = config.get("manifest_type")`
		`if not img.type:`
		`- if archive["type_name"] != "iso":`
		`+ if archive["type_name"] == "tar" and "wsl2" in archive["filename"]:`
		`+ # HACK: this should really be set in the compose configuration`
		`+ img.type = "wsl2"`
		`+ elif archive["type_name"] != "iso":`
		`img.type = archive["type_name"]`
		`else:`
		`fn = archive["filename"].lower()`

setup.py

file modified

+1 -1

		`@@ -56,7 +56,7 @@`
		`"jsonschema",`
		`"kobo",`
		`"lxml",`
		`- "productmd>=1.43",`
		`+ "productmd>=1.45",`
		`"dogpile.cache",`
		`],`
		`tests_require=["pytest", "pytest-cov"],`

lsedlar commented a month ago

OSBuild can generate images with tar.gz extension but import them to Koji with archive type set to tar. In such situation Pungi will not recognize the file and it will not be downloaded into the compose.

rebased onto 5731cce

a month ago

lsedlar commented a month ago

This would need a corresponding change in productmd. But the type is not very good, as it says nothing about what the image is. A different approach is needed here.

1 new commit added

osbuild: Add a hack to detect wsl images

a month ago

lsedlar commented a month ago

I have added another commit that automatically detects the image type. This is a horrible hack and only useful to avoid tricky timing of pungi deployment and compose configuration.

2 new commits added