#11258 Collaborators cannot merge PRs on src.fedoraproject.org
Closed: upstream by jnsamyak. Opened by dcavalca.

  • Describe the issue
    https://src.fedoraproject.org/rpms/subunit/pull-request/3 is a PR on the epel8 branch, which epel-packaging-sig has collaborator access on. I'm in the group, so I should be able to merge it, but I don't have the button in the UI.

  • When do you need this? (YYYY/MM/DD)
    not urgent

  • When is this no longer needed or useful? (YYYY/MM/DD)
    n/a

  • If we cannot complete your request, what is the impact?
    SIG members with collaborator permissions will need to bug the owner or leverage provenpackagers to merge changes.


Is this a releng issue or a Pagure issue that should be reported at pagure.io/pagure? It seems like the latter to me.

It's a dist-git configuration issue. Pagure normally supports it fine.

Metadata Update from @phsmoura:
- Issue tagged with: medium-gain, medium-trouble

I don't see any configuration around this off hand in pagure-dist-git...

@zlopez Any thoughts here were it might need to be fixed?

This might be an issue with the implementation of collaborator ACL's in pagure.

I think this is the reason: https://pagure.io/pagure/blob/master/f/pagure/templates/repo_pull_request.html#_173

Suspicion confirmed, we just need to update the if to consider committers and collaborators.

Shall we close this in favor of an upstream ticket/PR then?

Metadata Update from @jnsamyak:
- Issue assigned to jnsamyak

Opened a ticket in upstream to track stuff there: https://pagure.io/pagure/issue/5413, I am personally looking into the development of it!

Metadata Update from @jnsamyak:
- Issue close_status updated to: upstream
- Issue status updated to: Closed (was: Open)

Metadata