For icu specific context, see: https://src.fedoraproject.org/rpms/icu/pull-request/12
When do you need this? (YYYY/MM/DD) asap
When is this no longer needed or useful? (YYYY/MM/DD)
If we cannot complete your request, what is the impact?
@pwalter ^^ Please, do this via PRs and with coordination with maints of packages depending on icu, apart from the mentioned LO, this will require tweaks in my mozjsXYZ packages!
Also, it seems it was done on proven packager acl. Based on the context, I doubt it was coordinated with the proper icu maints.
In the past Pete did several ICU upgrades including providing binary compatibility packages, which was fine with me and usually happened after LibreOffice was adapted. Unfortunately this isn't the case here and due to people being busy with other things LO lags behind. See also PR 12 mentioned.
However, I agree the upgrade should be done in a side-tag so depending packages can be adapted.
When untagging icu-74.2-1.fc40 you probably also want to untag icu-74.1-1.fc40 which was built coupe hours earlier.
That ticket is ... unexpected.
Please see the devel mailing list for coordination. I have been handling icu major version bumps since 2017 and I do not think there is anyone else who knows better how to do them?
In short: please read devel mailing list. We need to bump icu versions so that other packages can start migrating over. Case in point: libreoffice has not had a major reason to update their code because Fedora has been shipping old icu. For those packages that are not ready, there is the libicu73 compatibility package that I introduced: libreoffice and mozjs will not be broken by icu update because they automatically start using the libicu73 compat package.
Dependent packages can get rebuilt at their own pace (there is no need to do it as a flag day because of the libicu73 compat package) and I offered to rebuild them over the weekend. Again, see the devel mailing list.
I did not know you were working on this yourself (the linked PR). For this I am sorry. Maybe send me an email next time so I know? I appreciate you taking the initiative with this and I could have avoided a lot of work had I known it.
That ticket is ... unexpected. Please see the devel mailing list for coordination. I have been handling icu major version bumps since 2017 and I do not think there is anyone else who knows better how to do them? In short: please read devel mailing list. We need to bump icu versions so that other packages can start migrating over.
In short: please read devel mailing list. We need to bump icu versions so that other packages can start migrating over.
What mailing list? At fedora-devel, the latest post with "icu" in Subject or Body is by me, announcing the upgrade to icu73. I don't see anything from you about icu there.
Case in point: libreoffice has not had a major reason to update their code because Fedora has been shipping old icu. For those packages that are not ready, there is the libicu73 compatibility package that I introduced: libreoffice and mozjs will not be broken by icu update because they automatically start using the libicu73 compat package.
They will become FTBFS. Compat package helps only with FTI, not the build problems. LibreOffice and mozjs builds will be broken by this bump.
What mailing list? There isn't anything about this in fedora-devel.
This is part is fine, I am okay with it, it wasn't that much of a work. I usually don't send out emails about bump PRs, I check them by default before working on something.
Date: Tue, 30 Jan 2024 22:14:33 +0000 Subject: HEADS UP: icu 74 coming to rawhide From: Pete Walter <walter.pete@yandex.com> To: Development discussions related to Fedora <devel@lists.fedoraproject.org>, Eike Rathke <erack@redhat.com> Message-Id: <2059351706652624@mail.yandex.com>
Hmm, "Why is this message in spam?" is also a question I am asking, apart from gmail...
ok, so are we good here now? Or is there still an issue?
Metadata Update from @kevin: - Issue tagged with: low-gain, low-trouble, ops
I'd say we should go ahead and untag this one and the icu-74.1-1.fc40. Then we (I can) need to go through the builds since the icu bump, and rebuild everything that depends on icu and has been rebuilt.
LO fix, at least according to the issues https://gerrit.libreoffice.org/c/core/+/158749 ; https://bugs.documentfoundation.org/show_bug.cgi?id=158108 doesn't seem near, and we don't want LO to be FTBFS as it's in the default package set.
FWIW, I wouldn't usually request an untag for FTBFS, only FTI. FTBFS is a less immediate problem, it doesn't break the immediate functionality of the distro, or stop composes working. It does sound like pwalter was aware of the consequences here and made the decision intentionally.
Yes and no: I was aware that a few packages always FTBFS after icu update, but I did not know about the libreoffice issue specifically. libicu73 compat package makes sure that any package that is not rebuilt yet does not break the distro and composes and maintainers can deal with any FTBFS issues at their own leisure.
btw libreoffice FTBFS is fixed: https://src.fedoraproject.org/rpms/libreoffice/pull-request/25
@frantisekz Can you help with mozjs rebuilds please?
Yeah, the mozjs stuff is fine, I'll handle that (together with https://bugzilla.redhat.com/show_bug.cgi?id=2260867 ), the LO thing is the thing that worries me.
edit: oh, the other distros had patches already, nice, closing this then.
Metadata Update from @frantisekz: - Issue close_status updated to: It's all good - Issue status updated to: Closed (was: Open)
Thank you!
Log in to comment on this ticket.