Learn more about these different git repos.
Other Git URLs
The error message is:
$ ./give-package.py rpms/libkolab tpokorra Giving rpms/libkolab to tpokorra {'error': 'You are not allowed to modify this project', 'error_code': 'EMODIFYPROJECTNOTALLOWED'} Traceback (most recent call last): File "./give-package.py", line 49, in <module> main() File "./give-package.py", line 45, in main utilities.give_package(session, namespace, package, args.custodian) File "/home/till/scm-genius/opensource/fedora/releng-git/scripts/distgit/utilities.py", line 62, in give_package raise IOError("Failed PATCH %r %r" % (response.request.url, response)) OSError: Failed PATCH 'https://src.fedoraproject.org/api/0/rpms/libkolab' <Response [401]>
Maybe this is related to https://pagure.io/pagure-dist-git/issue/19
@pingou, could you please take a look? I created an admin token on pkgs with @ralph's help.
Metadata Update from @till: - Issue assigned to pingou
Another idea might be that this is not yet deployed, is it? https://pagure.io/pagure/issue/2515
The fix for issue pagure#2515 is deployed.
But I think it relates to https://pagure.io/pagure-dist-git/issue/19 indeed
The fix for issue #2515 is deployed.
@pingou You linked to a issue not a fix.
@mohanboddu I'm answering to a question about an issue. But if you go to https://pagure.io/pagure/issue/2515 you can see a comment saying PR https://pagure.io/pagure/pull-request/2516 addresses this
PR https://pagure.io/pagure/pull-request/2516 addresses this
@pingou Okay, the problem is #2515 linked to releng issue that is https://pagure.io/releng/issue/2515 not the pagure issue(https://pagure.io/pagure/issue/2515)
edited :)
I still get the initial traceback. It seems that the web interface now recognizes me as admin but it claims that the user I wanted to add is not in the packager group but he is. Project rpms/libkolab, user: tpokorra
@till My guess would be the problem is that user needs to log in to pagure to get groups synced
Another guess, does this code maybe need to update the API user's FAS groups as well?: https://pagure.io/pagure/blob/master/f/pagure/api/__init__.py#_126
@kevin noticed that pagure does not seem to recognize the cvsadmin group, it is missing here: https://src.fedoraproject.org/user/till https://src.fedoraproject.org/user/kevin https://src.fedoraproject.org/group/cvsadmin
What needs to be done to add the group to the system?
@till the group woul have to be synced from fas, in the hosts fas config
I tried to find the location for this in ansible. When I look at @kevin's groups he is in infra-sig according to https://src.fedoraproject.org/user/kevin
The infra-sig group is only mentioned in the bodhi config in ansible. https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/inventory/group_vars/pkgs might be the file you mean but I am not sure if it is the place that needs to be adjusted.
Also I realized that dist-git-pagure does not seem to know the provenpackager group as well. Not sure if this is an issue somehow as well...
This should now be fixed. Please note that cvsadmin users will need to log out of src.fp.o and log back in to have group membership be synced.
Provenpackager is now also known to Pagure on dist-git.
FYI @till
@puiterwijk fixed the issue, just log out and log back in and you can see cvsadmin permissions.
@till Closing the ticket as Patrick fixed it.
Solved https://pagure.io/releng/issue/7043
Metadata Update from @mohanboddu: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Afaik this wasn't needed, we may even want to remove it. Let's see
Provenpackager is now also known to Pagure on dist-git. Afaik this wasn't needed, we may even want to remove it. Let's see
Is it not required for them to be able to merge pull requests on other repos? Btw. I still do not understand why I had partial admin privileges in the web UI, i.e. I could add myself as admin to any project or remove admins from other projects except for the main admin. IIRC this only happened after the cvsadmin group was added to pagure's config file.
Metadata Update from @till: - Issue status updated to: Open (was: Closed)
Is it not required for them to be able to merge pull requests on other repos?
We do not support provenpackager being able to merge PR via the UI.
I could add myself as admin to any project or remove admins from other projects except for the main admin.
This is fixed in 3.8 and it due to you being an "instance wide" admin. So be careful with these rights :)
Closing the ticket since its fixed by @puiterwijk
Log in to comment on this ticket.