#9246 Please block `fedora-cisco-openh264` from pungi composes
Closed: Fixed 5 years ago by mohanboddu. Opened 5 years ago by ngompa.

Describe the issue

The Fedora Workstation WG has decided that we want the fedora-cisco-openh264 repo enabled by default for Fedora 32 and later. In order to implement this in a way that complies with current policy, we need composes (and only composes) to have this repo disabled so that weak dependencies do not pull in software into the media and install trees distributed by Fedora.

When do you need this? (YYYY/MM/DD)

We need this as soon as the PRs to fedora-repos are merged and built:

When is this no longer needed or useful? (YYYY/MM/DD)

If the PRs are not merged, then I guess we wouldn't need this.

If we cannot complete your request, what is the impact?

We might accidentally ship OpenH264 codec packages on our media, which would be... bad.


Chat with @lsedlar

[09:40:01] <mboddu> So, I am working on https://pagure.io/releng/issue/9246
[09:40:39] <mboddu> We want to enable openh264 repos, but we dont to pull any packages from it while composing images
[09:40:56] <mboddu> aka, the images shouldn't come with any packages preinstalled from openh264 repos
[09:41:30] <mboddu> I checked kickstarts, comps and pungi configs they dont have any thing related to openh264 in them
[09:41:48] <mboddu> But that doesn't mean openh264 cant pulled because of a weak dep
[09:41:56] <mboddu> How can we solve this?
[09:42:13] <lsedlar> by images you mean live media and such, right?
[09:42:30] <mboddu> live media, dvd, iso...
[09:43:34] <lsedlar> and you want to put a .repo file into fedora-repos that's enabled by default, but nothing from it should be in the image
[09:43:48] <mboddu> Yes
[09:44:09] <lsedlar> for dvd and netinst iso Pungi consumes images from it's own repo based on Koji tag, no matter what files are installed on the system; I'm pretty sure the open264 packages could get in there
[09:45:22] <mboddu> openh264 packages are built in a separate tag, if I am not wrong
[09:45:23] <lsedlar> also when live media tasks are run, one of the parameters is a list of repos from which the packages can be installed; I don't think the openh264 repo being enabled would actually show up there
[09:45:24] »» mboddu checks
[09:46:33] <mboddu> Yes, they are built in a separate tag
[09:48:06] <lsedlar> it would probably be best to test this (maybe even ask to install openh264 in a kickstart and see if the image fails to build)
[09:48:35] <lsedlar> but I don't see how the package can get into the images just by making a change in fedora-repos package
[09:49:33] <mboddu> Okay, I will try the image build with a kickstart with openh264 stuff in it
[09:50:04] <mboddu> And for dvd and netinst is your statement above is right? "I'm pretty sure the open264 packages could get in there" or is it "could not get in there"?
[09:50:23] <lsedlar> oh my, that's a bad typo
[09:50:48] <lsedlar> could *not* get in there
[09:51:08] <lsedlar> DVD only contains stuff that's in the generated repo
[09:51:09] <mboddu> Good, I was a bit worried there :)
[09:51:39] <lsedlar> and lorax installs everything in one transaction IIRC, so by the time fedora-repos is installed, so is everything else
[09:51:45] <mboddu> So, as long as openh264 are built in a separate tag, we should be fine
[09:52:18] <lsedlar> yes, I think so
[09:52:50] <mboddu> Okay, I will check with kalev just to confirm it and will try to build a image with openh264 packages in it and see what happens
[09:52:55] <mboddu> Thanks for the help

I will test it later today

Closing as the work is done.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Log in to comment on this ticket.

Metadata