Learn more about these different git repos.
Other Git URLs
The rpms/libeconf package is configured such that the package is built for all Fedora releases from the master branch with no automatic branching on new releases. However, it looks like f32 and f33 branches were created accidentally from the master branch when Fedora 32 and Fedora 33 branched from Rawhide. Can this please be removed, as all commits in f32 and f33 branches are in master branch.
rpms/libeconf
master
f32
f33
When do you need this? (YYYY/MM/DD) ASAP.
When is this no longer needed or useful? (YYYY/MM/DD) I guess when F33 EOL?
If we cannot complete your request, what is the impact? I have a random branch that people expect is used when it isn't.
Metadata Update from @mohanboddu: - Issue tagged with: groomed, medium-gain, medium-trouble
Running the check script:
$ python ~/repos/gitrepo/releng/scripts/distgit-branch-unused.py f32 --repository . Checking package libeconf in .../libeconf Found branch f32 in bodhi with tags: f32-container, f32-container-updates, f32-container-updates-testing, f32-container-updates-candidate, f32-container-updates-testing-pending, f32-container-updates-pending, f32-container-override Checking for libeconf in tag f32-container... (no) Checking for libeconf in tag f32-container-updates... (no) Checking for libeconf in tag f32-container-updates-testing... (no) Checking for libeconf in tag f32-container-updates-candidate... (no) Checking for libeconf in tag f32-container-updates-testing-pending... (no) Checking for libeconf in tag f32-container-updates-pending... (no) Checking for libeconf in tag f32-container-override... (no) No builds found in koji for branch f32 Branch merged into refs/heads/master. Safe to delete.
Looks good to do
This happened again with F33 branching, so I've updated the ticket accordingly.
Metadata Update from @pingou: - Issue assigned to pingou
Ran server side:
mv refs/heads/f32 heads_f32
Checked locally:
$ git fetch -p From ssh://pkgs.fedoraproject.org/rpms/libeconf - [deleted] (none) -> origin/f32
Looks good! :)
Metadata Update from @pingou: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Unfortunately, this is not possible currently :disappointed:
[09:45:20] <pingou> mboddu: do you want to take that one ^ ? I'll do https://pagure.io/fedora-infrastructure/issue/8692 [09:45:31] <+mboddu> pingou: Sure [09:45:34] <+mboddu> I got into pkgs01 [09:46:02] <+mboddu> Eighth_Doctor: I will take care of it now [09:46:23] <Eighth_Doctor> mboddu: awesome, thanks! [09:46:43] <Eighth_Doctor> there's also this fun one: https://pagure.io/releng/issue/9549 [09:47:01] <Eighth_Doctor> there's now an f33 branch [09:47:05] <Eighth_Doctor> I'm not sure what's going on here [09:47:15] <Eighth_Doctor> when I created the repo, I requested no auto-branching [09:47:44] <Eighth_Doctor> mboddu: do you know if something is misconfigured? [09:47:45] <+mboddu> Eighth_Doctor: I will take a look at it after the clean ups [09:47:53] <+mboddu> Eighth_Doctor: Thats what my guess is [09:48:58] <+mboddu> Eighth_Doctor: How did you setup not to auto-branch it? [09:48:59] <Eighth_Doctor> thanks [09:50:05] <Eighth_Doctor> `--no-git-branch` when setting up the repo and PDC targets? [09:50:25] <pingou> it'll still be branched at mass-branching [09:50:32] <pingou> so the f33 branch isn't surprising [09:50:35] <Eighth_Doctor> ah [09:50:56] <Eighth_Doctor> so that repo is my experiment with maintaining a package without branches [09:51:06] <Eighth_Doctor> using `package.cfg` [09:51:31] <pingou> I can do f33 but I don't think this is sustainable [09:51:58] <Eighth_Doctor> yeah, it's definitely not [09:52:21] <Eighth_Doctor> I could just end my experiment and go back to the other way [09:52:34] <Eighth_Doctor> but I figured if nobody tried the workflow, we'd never improve it [09:52:52] <+mboddu> Eighth_Doctor: Okay, I never played with --no-git-branch, checking it... [09:54:19] <+mboddu> Eighth_Doctor: buildbot should be fixed now [09:55:04] <Eighth_Doctor> thank you so much Mohan! [09:55:21] <pingou> mboddu: going to document the procedure in the howto repo :D [09:55:42] <+mboddu> pingou: Sure, thanks a lot [09:55:46] <pingou> --no-git-branch doesn't create the git branch when the repo is created [09:56:09] <pingou> but it doesn't save that setting anywhere, so the repo is branched at mass-branching [09:56:55] <+mboddu> pingou: Yeah, I guess as long there is a master with validity in pdc, the branches will get created [09:57:43] <pingou> yup [09:58:12] <pingou> Eighth_Doctor: amusingly, if you were to retire the master branch and use a "devel" branch or so, it would work better [09:58:22] <pingou> except that retiring the master branch will have... consequences :D [09:59:01] <pingou> unless you request that devel branch via fedpkg request-branch so it shows up in PDC (no idea if that would be supported) [09:59:05] <+mboddu> Nope that will not fix, if retired on master that will block it in koji [09:59:08] <Eighth_Doctor> yeah... I'm adventurous, but not that adventurous [09:59:33] <pingou> mboddu: not if there is another active branch [09:59:44] <pingou> otherwise we couldn't have epel-only packages [10:00:17] <+mboddu> pingou: Nope, again, blocking checks the pdc for valid branches and blocks them in koji [10:00:42] <+mboddu> So, if epel branches in pdc are not retired they will work, since they have their own build target in koji [10:00:47] <pingou> mboddu: so if it finds another active branch in pdc, it won't block in koji [10:01:44] <+mboddu> Its a mapping, eol'd in master means block in f34 tag, eol'd in f33 means block in f33 tag, eol'd in epel8 branch means block in epel8 tag [10:02:24] <pingou> hm ok [10:02:28] <pingou> oh well :) [10:02:42] <+mboddu> If master is retired, then the pkg gets blocked in f34 (current rawhide), even though the maintainer can specify rawhide target in packages.cfg in devel branch, since its blocked they cant build it [10:02:45] <pingou> Eighth_Doctor: so you'll have an f34 branch :D [10:05:17] <+mboddu> Maybe we can improve the branching script to check a file in master branch 'noautobranch', that will work to keep the master alive and use packages.cfg and will not branch? [10:08:32] <pingou> it should be in pdc I think [10:08:34] <pingou> but pdc...
Metadata Update from @mohanboddu: - Assignee reset - Issue close_status updated to: Can't Fix (was: Fixed)
Log in to comment on this ticket.